Newbie C question

ramyh96 · Apr 17, 2018

Hello, I'm trying to make a function to scan 5 numbers from the user and to print the minimum, but once I run it, it's printing the last inputted number:

{
int i, num, min,k;
for (i=0;i<5;i++){
scanf("%d",&num);
for (k=0;k<1;k++){
min=num;
}
if (num<min){
min=num;
}

}

printf("%d",min);
}

pasdoy · Apr 18, 2018

what are you trying to do exactly?

Code:

#include <stdio.h>

int main(void) {
    int i, num, min,k;
    for (i=0;i<5;i++){

        //here you put the input in a int called num
        scanf("%d",&num);

        //here you assign num to min
        for (k=0;k<1;k++){
            min=num;
        }

        // here you check if num is smaller than min, but num is already min so it will always be false.
        if (num<min){
            min=num;
        }

    }

    printf("%d",min);
    return 0;
}

pasdoy · Apr 18, 2018

maybe this is what you want https://ideone.com/2ZEJXl. stackoverflow has some fancy way for you to do it too.

designhut · Jul 11, 2018

You have to store 5 numbers in array otherwise it will be overwritten

maxsch0610 · Jul 30, 2018

<code>
#include <stdio.h>

int main(void) {
int i, num, min,k;
for (i=0;i<5;i++){

scanf("%d",&num);

if (num<min){
min=num;
}

}

printf("%d",min);
return 0;
}
</code>
i think you messed it a liitle bit up now it should work as i understood

billionaire2050 · Jul 31, 2018

maxsch0610 said:
<code>
#include <stdio.h>

int main(void) {
int i, num, min,k;
for (i=0;i<5;i++){

scanf("%d",&num);

if (num<min){
min=num;
}

}

printf("%d",min);
return 0;
}
</code>
i think you messed it a liitle bit up now it should work as i understood

Shouldn’t you also initialise min before using it in the loop?
May be like min=0 or min=-65535 if you’re also inputting negative values.

pasdoy · Jul 31, 2018

you can put min=INT_MAX like in my example file

mobile_man · Oct 10, 2018

ramyh96 said:
Hello, I'm trying to make a function to scan 5 numbers from the user and to print the minimum, but once I run it, it's printing the last inputted number:

{
int i, num, min,k;
for (i=0;i<5;i++){
scanf("%d",&num);
for (k=0;k<1;k++){
min=num;
}
if (num<min){
min=num;
}

}

printf("%d",min);
}

In your code invariant num < min is always false and that's why your code have wrong behavior. Just remove this useless cycle with k and it will work. Also initialize min with INT_MAX as other's stated before.

filip325 · Oct 16, 2018

I'm not sure what you tried to do there. But i suggest storing these numbers inside array and just traversing array and picking minimum number. There is no need to assign minimum to INT_MAX, you can just assume that first number in array is minimum.

Newbie C question

ramyh96

BANNED

pasdoy

Senior Member

pasdoy

Senior Member

designhut

Newbie

maxsch0610

Newbie

billionaire2050

Junior Member

pasdoy

Senior Member

mobile_man

Newbie

filip325

Registered Member

Main Menu

Marketplace

Making Money

BlackHat World