Is my strategy good?

Hi, instead of having different sites for different niches/product I have one site with different categories on it and the url is universal/isn't specific. Can this still work to make me money with Clickbank instead of promoting single sites? Thanks!

That sounds like a good idea. That is what http://www.outdoorgearlab.com/ however with this method it may take a while to rank for keywords if you are creating it on a new domain name. I recommend you scrape for a expired brandable domain name with good metrics or purchase one from a reputable buyer.

The drawback with this method is that if a google algo update changes something, your site as a whole will be affected. When building different sites on specific niches however, you won't be affected as a whole and you might use the same seo tactics on those different domains, something that will be impossible when building and authority site.

In general, when I'm trying to make money out of my sites, I prefer to use separate sites. It proves to be a better tactic most of the times.