1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

I Found a Bug in WP 2.8.4

Discussion in 'Blogging' started by The Scarlet Pimp, Aug 18, 2009.

Thread Status:
Not open for further replies.
  1. The Scarlet Pimp

    The Scarlet Pimp Jr. VIP Jr. VIP Premium Member

    Joined:
    Apr 2, 2008
    Messages:
    788
    Likes Received:
    3,128
    Occupation:
    Chair moistener.
    Location:
    Cyberspace
    I was installing 2.8.4 and I noticed this bug in the wp-config-sample.php file. See below...

    Original Code:
    /** Sets up WordPress vars and included files. */
    require_once(ABSPATH . 'wp-settings.php');



    It Should Be Like This:
    /** Sets up WordPress vars and included files. */
    require_once(ABSPATH . 'wp-settings.php');
    ?>


    As you can see, the php closing tag (?>) is missing at the end. Dunno how much trouble this may cause, but it should be fixed to prevent any troubles.
     
  2. tsanko

    tsanko Senior Member

    Joined:
    Aug 9, 2008
    Messages:
    833
    Likes Received:
    1,038
    Home Page:
    Report it in WP forum and they will fix it:)
     
  3. oldenstylehats

    oldenstylehats Elite Member Premium Member

    Joined:
    Apr 10, 2008
    Messages:
    1,893
    Likes Received:
    1,196
    If the file only contains PHP code, then you don't have to use a closing tag.
     
  4. The Scarlet Pimp

    The Scarlet Pimp Jr. VIP Jr. VIP Premium Member

    Joined:
    Apr 2, 2008
    Messages:
    788
    Likes Received:
    3,128
    Occupation:
    Chair moistener.
    Location:
    Cyberspace
    the closing tag is present in version 2.7.1 so i am assuming it should be present here as well.
     
  5. oldenstylehats

    oldenstylehats Elite Member Premium Member

    Joined:
    Apr 10, 2008
    Messages:
    1,893
    Likes Received:
    1,196
    Not necessarily. Regardless, report it if you want, but it isn't a bug.
     
  6. The Scarlet Pimp

    The Scarlet Pimp Jr. VIP Jr. VIP Premium Member

    Joined:
    Apr 2, 2008
    Messages:
    788
    Likes Received:
    3,128
    Occupation:
    Chair moistener.
    Location:
    Cyberspace
    i see yet another 'upgrade' coming... :D
     
  7. The Scarlet Pimp

    The Scarlet Pimp Jr. VIP Jr. VIP Premium Member

    Joined:
    Apr 2, 2008
    Messages:
    788
    Likes Received:
    3,128
    Occupation:
    Chair moistener.
    Location:
    Cyberspace
    you're right, it isn't a bug, it's a typo.
     
  8. oldenstylehats

    oldenstylehats Elite Member Premium Member

    Joined:
    Apr 10, 2008
    Messages:
    1,893
    Likes Received:
    1,196
    Dude. Come on. It isn't a typo either. It is a coding convention.

    EDIT:
    By removing the closing tag, it stops the accident insertion of white space after the closing tag, which was a common problem with manual WordPress installations. It was removed for a reason.
     
  9. The Scarlet Pimp

    The Scarlet Pimp Jr. VIP Jr. VIP Premium Member

    Joined:
    Apr 2, 2008
    Messages:
    788
    Likes Received:
    3,128
    Occupation:
    Chair moistener.
    Location:
    Cyberspace
    will ask at their forum, maybe it's an exciting new 'feature'. :D :D
     
  10. The Scarlet Pimp

    The Scarlet Pimp Jr. VIP Jr. VIP Premium Member

    Joined:
    Apr 2, 2008
    Messages:
    788
    Likes Received:
    3,128
    Occupation:
    Chair moistener.
    Location:
    Cyberspace
    so php scripts can run fine without the closing tag? interesting...
     
  11. oldenstylehats

    oldenstylehats Elite Member Premium Member

    Joined:
    Apr 10, 2008
    Messages:
    1,893
    Likes Received:
    1,196
    It is revision 10252 of the WordPress code base which fixes ticket #6791. Yes. If the file only contains PHP code, then it isn't an issue. In fact, in some cases removing the closing tags will take care of issues with the header not being fully passed due to white space at the end of the file.
     
  12. The Scarlet Pimp

    The Scarlet Pimp Jr. VIP Jr. VIP Premium Member

    Joined:
    Apr 2, 2008
    Messages:
    788
    Likes Received:
    3,128
    Occupation:
    Chair moistener.
    Location:
    Cyberspace
    that is a bit of a relief. can you delete this thread since it's not an issue?

    thanx!
     
Thread Status:
Not open for further replies.